-
Notifications
You must be signed in to change notification settings - Fork 16
Try building latest OpenBLAS release: v0.3.5 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try building latest OpenBLAS release: v0.3.5 #1
Conversation
Also, since nobody has ever opened a pull request here I'm not sure if the CI is designed to handle PR OpenBLAS builds gracefully & if the cost of building a PR and then merging / building again is undesirably high. |
One other question -- are the manual processing steps for MacOS platform still needed? |
I never much enjoyed those 'build-passing' badges, partly because the builds could fail for no good reason - but if you like them, please go ahead. |
No - there's no need for the manual processing steps for the Mac library now, we aren't shipping dual-arch any more. |
PRs are fine, I think. It's not crazy long, and there won't be many PRs, I don't suppose. |
Builds look ok to me, but PRs don't seem to have access to the secret API key needed to upload to the server. I suppose that makes sense--otherwise anyone could open a PR and start dumping files on the server. So, if this looks good to you, presumably it has to be merged for the uploads to happen. |
Well - I think the API key is encrypted to the repo - so I think that PRs from the main repo, to the same repo but master branch, will upload, but I might be wrong. |
You can check the wheelhouse upload command logs near the end of this PR CI builds vs. your last push to master to see the difference, I think. There's a warning on the PR but not on your pushes. |
Right - I would have predicted that because the PR comes from your repo. If you'd made a branch in this MacPython repo, and then done a PR from that, I would predict an upload. But I'm speculating. |
Wouldn't I need commit rights to push the branch to the repo to open the PR? That was the motivation for the fork in the first place. |
Yes, right - and you're welcome to those if you don't have them - but it would only be necessary if you needed the upload as part of the PR. I'm guessing that usually the PRs will be getting the build steps right, and the upload will only be needed after the merge. |
That sounds right. If I work with you / Carl eventually to make less trivial adjustments to the build then uploading by default would not be desirable on more substantive PRs I suspect. |
Are you happy to merge this or do you want more changes here? |
Yes, all good .. |
Related to discussion in: numpy/numpy#13173
cc @matthew-brett & @charris
Looks like I can just use the version tag for building at the exact release point based on project history. This should bump the version built from
v0.3.5.dev
(at a specific development hash) tov0.3.5
proper.I note that there are no badges / links in the
openblas-libs
README for monitoring the CI builds of OpenBLAS, which might be useful to have?